Re: gitk from subdirectory

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 31, 2007, 05:29 UTC
Message-ID: <7vsl6046gn.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LFD.0.999.0708302200160.25853@woody.linux-foundation.org>

Linus Torvalds <torvalds@linux-foundation.org> writes:

Show 26 quoted lines

> On Thu, 30 Aug 2007, Junio C Hamano wrote:
>> 
>> I am wondering if this was intended behaviour change.  I think
>> it makes sense to want an easy way to say "what changed stuff in
>> the directory I am in?" because presumably you are there because
>> you are interested in stuff in there.  But if you hard code "--"
>> it is not easy to disable that and get the global log.
>
> Hmm. My reaction to this would be that it was a mistake to have a 
> difference between 
>
> 	git log --
>
> and
>
> 	git log
>
> and that we should instead fix this at the argument parsing level. 
>
> And then anybody who depended on the old "--" behaviour can just add a "." 
> at the end.
>
> That way there are no special cases.
>
> I realize that the "--" behaviour of git log was intentional, but seeing 
> what it results in I think the intention was good, but stupid.

I haven't finished analysis yet, but I was reaching the same conclusion.

v1.2.0 used to limit "git rev-list" to the current working directory, v1.3.0 and newer does not. But they do when "--" is given. This makes it impossible to do:

	cd Documentation
	echo >master
	git rev-list master
        ... get "ambiguous -- which do you mean?  rev, or
	... limited to path?" error message
        git rev-list master --
        ... I do mean unlimited and dig from 'master'