git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Buffer overflows

From
Linus Torvalds <torvalds@linux-foundation.org>
Date
Aug 30, 2007, 20:46 UTC
Message-ID
<alpine.LFD.0.999.0708301340470.25853@woody.linux-foundation.org>
In-Reply-To
<1188502009.29782.874.camel@hurina>
On Thu, 30 Aug 2007, Timo Sirainen wrote:
>
> Looks like nothing has happened since my last mail about this
> (http://marc.info/?l=git&m=117962988804430&w=2).

Perhaps because your patch was using a totally nonstandard and slow interface, and had nasty string declaration issues, as people even pointed out to you.

If you were to send in a patch that simply just fixed some random case without introducing the other stuff in forms that nobody is used to, people would probably react more.

Especially since:
> I sure hope no-one's using git-mailinfo to do any kind of automated mail 
> processing from untrusted users.

Obviously nobody would do that. Not because of any email buffer overflows, but because people wouldn't want to apply untrusted patches in the first place!

IOW, if I don't trust the mail, I'd sure as hell not apply it - not because I'm afraid the email is misformed, but because I'd not trust the *patch*.

			Linus
Previous: Lukas SandströmNext: Timo Sirainen
Message 3 of 26 in “Buffer overflows”
  1. Timo SirainenAug 30, 2007
  2. Lukas SandströmAug 30, 2007
  3. Linus TorvaldsAug 30, 2007
  4. Timo SirainenAug 30, 2007
  5. Reece DunnAug 30, 2007
  6. Timo SirainenAug 30, 2007
  7. Reece DunnAug 30, 2007
  8. Wincent ColaiutaAug 31, 2007
  9. Simon 'corecode' SchubertAug 31, 2007
  10. Junio C HamanoAug 30, 2007
  11. Pierre HabouzitAug 30, 2007
  12. Timo SirainenAug 30, 2007
  13. Johan HerlandSep 2, 2007
  14. Reece DunnSep 2, 2007
  15. David KastrupSep 2, 2007
  16. Reece DunnSep 2, 2007
  17. Jakub NarebskiSep 3, 2007
  18. Junio C HamanoSep 3, 2007
  19. René ScharfeSep 2, 2007
  20. Lukas SandströmSep 2, 2007
  21. Linus TorvaldsAug 31, 2007
  22. Timo SirainenAug 31, 2007
  23. Andreas EricssonAug 31, 2007
  24. Johannes SchindelinAug 31, 2007
  25. Temporary fix for stack smashing in mailinfoAlex Riesen, Aug 30, 2007
  26. Junio C HamanoAug 30, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.