Re: Fix "git commit directory/" performance anomaly

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Aug 10, 2007, 18:56 UTC
Message-ID: <alpine.LFD.0.999.0708101154530.30176@woody.linux-foundation.org>
In-Reply-To: <7vsl6rs0l5.fsf@assigned-by-dhcp.cox.net>

On Fri, 10 Aug 2007, Junio C Hamano wrote:

Show 7 quoted lines

> Linus Torvalds <torvalds@linux-foundation.org> writes:
> 
> > This trivial patch avoids re-hashing files that are already clean in the 
> > index. This mirrors what commit 0781b8a9b2fe760fc4ed519a3a26e4b9bd6ccffe 
> > did for "git add .", only for "git commit ." instead.
> 
> Makes sense.  Thanks.

Please don't apply that patch without this trivial fix.

I don't know why I didn't notice. It passed all the tests, but it really shouldn't have, and the compiler warned.

		Linus

---

diff --git a/builtin-update-index.c b/builtin-update-index.c
index 8d22dfa..a7a4574 100644
--- a/builtin-update-index.c
+++ b/builtin-update-index.c
@@ -91,7 +91,7 @@ static int add_one_path(struct cache_entry *old, const char *path, int len, stru
 
 	/* Was the old index entry already up-to-date? */
 	if (old && !ce_stage(old) && !ce_match_stat(old, st, 0))
-		return;
+		return 0;
 
 	size = cache_entry_size(len);
 	ce = xcalloc(1, size);