Re: possible bug in git apply?

From

Linus Torvalds <torvalds@linux-foundation.org>

Date

Aug 5, 2007, 04:48 UTC

Message-ID

<alpine.LFD.0.999.0708042141510.5037@woody.linux-foundation.org>

In-Reply-To

<Pine.LNX.4.64.0708041243070.6905@asgard.lang.hm>

On Sat, 4 Aug 2007, david@lang.hm wrote:

>
> since git doesn't track directories, only content (per the big discussion
> recently) I beleive that doing a checkout would leave Rob without the
> directories that he emptied out, so shouldn't git apply also clear the
> directories to end up in the same state?

It should. I thought we did that, but maybe there's some bug there.

See "remove_file()" in builtin-apply.c.

Does this fix it? Totally untested, but it _looks_ obvious enough..

		Linus

---

diff --git a/builtin-apply.c b/builtin-apply.c
index 0a0b4a9..da27075 100644
--- a/builtin-apply.c
+++ b/builtin-apply.c
@@ -2508,7 +2508,7 @@ static void write_out_one_result(struct patch *patch, int phase)
 	 * thing: remove the old, write the new
 	 */
 	if (phase == 0)
-		remove_file(patch, 0);
+		remove_file(patch, patch->is_rename);
 	if (phase == 1)
 		create_file(patch);
 }