Re: possible bug in git apply?
- From
David Kastrup <dak@gnu.org>
- Date
- Aug 5, 2007, 07:55 UTC
- Message-ID
- <857ioact4u.fsf@lola.goethe.zz>
- In-Reply-To
- <7vvebuh8g8.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <gitster@pobox.com> writes:
Show 18 quoted lines
> Linus Torvalds <torvalds@linux-foundation.org> writes: > >> It should. I thought we did that, but maybe there's some bug there. >> >> See "remove_file()" in builtin-apply.c. >> >> But yeah, it seems that the file *rename* ends up not triggering that >> logic! Very annoying. >> >> Does this fix it? Totally untested, but it _looks_ obvious enough.. > > That would regress the fix made in aea19457, I am afraid. If > you are in a subdirectory and the rename patch moves away the > last file in your current directory, the shell session you ran > the git-apply from will end up in an unlinked directory. > > Maybe that is a pilot error, and we can revert aea19457 > altogether?
I'd call it pilot error. We can't really have git's behavior depend on where somebody might point his cwd. If we do that, we may never remove any directory. Once git tracks directories, it will be harder to make this particular pilot error (git rm ../mycwd is more obviously having this effect than git rm *), but a pilot error it is in my book.
-- David Kastrup, Kriemhildstr. 15, 44793 Bochum