git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Unify write_index_file functions

From
Nicolas Pitre <nico@cam.org>
Date
Jun 1, 2007, 21:01 UTC
Message-ID
<alpine.LFD.0.99.0706011655130.12885@xanadu.home>
In-Reply-To
<56b7f5510706011316v6e4c6f9fj33ae61f0b30f1772@mail.gmail.com>
On Fri, 1 Jun 2007, Dana How wrote:
> (2) write_idx_file has a sha1 argument with different in & out meanings,
> requiring copies at some call sites.  Should this be 2 separate args?

I think the copy could be avoided entirely. The pack_file_sha1 array doesn't need to have global scope. The simple sha1[20] array with this patch can serve the pack_file_sha1 purpose as well just fine.

Nicolas
Previous: Dana HowNext: Nicolas Pitre
Message 5 of 6 in “Unify write_index_file functions”
  1. Unify write_index_file functionsGeert Bosch, Jun 1, 2007
  2. Junio C HamanoJun 1, 2007
  3. Unify write_index_file functionsGeert Bosch, Jun 1, 2007
  4. Dana HowJun 1, 2007
  5. Nicolas PitreJun 1, 2007
  6. Nicolas PitreJun 1, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.