From: Nicolas Pitre <nico@cam.org>
Date: Fri, 01 Jun 2007 21:01:00 GMT
Subject: Re: [PATCH] Unify write_index_file functions
Message-ID: <alpine.LFD.0.99.0706011655130.12885@xanadu.home>
In-Reply-To: <56b7f5510706011316v6e4c6f9fj33ae61f0b30f1772@mail.gmail.com>

On Fri, 1 Jun 2007, Dana How wrote:

> (2) write_idx_file has a sha1 argument with different in & out meanings,
> requiring copies at some call sites.  Should this be 2 separate args?

I think the copy could be avoided entirely.  The pack_file_sha1 array 
doesn't need to have global scope.  The simple sha1[20] array with this 
patch can serve the pack_file_sha1 purpose as well just fine.


Nicolas