git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] builtin-pack-objects: don't fail, if delta is not possible

From
Nicolas Pitre <nico@cam.org>
Date
May 29, 2007, 02:45 UTC
Message-ID
<alpine.LFD.0.99.0705282243280.11491@xanadu.home>
In-Reply-To
<11803872591522-git-send-email-mkoegler@auto.tuwien.ac.at>
On Mon, 28 May 2007, Martin Koegler wrote:
Show 6 quoted lines
> If builtin-pack-objects runs out of memory while finding
> the best deltas, it bails out with an error.
> 
> If the delta index creation fails (because there is not enough memory),
> we can downgrade the error message to a warning and continue with the
> next object.

In the same vain, there is one realloc() that was turned into a xrealloc() in diff-delta.c. I think this was a mistake and should probably be a non fatal realloc again to let the caller go on.

Nicolas
Previous: Dana HowNext: Shawn O. Pearce
Message 5 of 6 in “builtin-pack-objects: don't fail, if delta is not possible”
  1. 1/3 builtin-pack-objects: don't fail, if delta is not possibleMartin Koegler, May 28, 2007
  2. 2/3 git-pack-objects: cache small deltas between big objectsMartin Koegler, May 28, 2007
  3. 3/3 builtin-pack-object: cache small deltasMartin Koegler, May 28, 2007
  4. Dana HowMay 29, 2007
  5. Nicolas PitreMay 29, 2007
  6. Shawn O. PearceMay 29, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.