From: Nicolas Pitre <nico@cam.org>
Date: Tue, 29 May 2007 02:45:16 GMT
Subject: Re: [PATCH 1/3] builtin-pack-objects: don't fail, if delta is not possible
Message-ID: <alpine.LFD.0.99.0705282243280.11491@xanadu.home>
In-Reply-To: <11803872591522-git-send-email-mkoegler@auto.tuwien.ac.at>

On Mon, 28 May 2007, Martin Koegler wrote:

> If builtin-pack-objects runs out of memory while finding
> the best deltas, it bails out with an error.
> 
> If the delta index creation fails (because there is not enough memory),
> we can downgrade the error message to a warning and continue with the
> next object.

In the same vain, there is one realloc() that was turned into a 
xrealloc() in diff-delta.c.  I think this was a mistake and should 
probably be a non fatal realloc again to let the caller go on.


Nicolas