Re: [PATCH v1 3/3] git-gui hooks for new config variable "diff.primer"
- From
Keith Cascio <keith@cs.ucla.edu>
- Date
- Jan 25, 2009, 18:58 UTC
- Message-ID
- <alpine.GSO.2.00.0901251045090.12651@kiwi.cs.ucla.edu>
- In-Reply-To
- <alpine.DEB.1.00.0901251918230.14855@racer>
On Sun, 25 Jan 2009, Johannes Schindelin wrote:
Show 6 quoted lines
> Rather than storing the information about how to call "git diff" as > diff.primer, why don't you store that information in a config variable > gui.whiteSpaceMode and teach "git gui" to call "git diff" accordingly? > > That would have the further advantage of not breaking other people's > setups...
This wasn't just for the GUI. Using Git for a project I imported from CVS, I wanted --ignore-space-at-eol to be in effect at all times on the command line. Of course, the "alias.dff" approach suggested yesterday by Teemu would work for that. But I got the feeling this is a more general need. I'll name my primary inspiration: ExamDiff (a Windows program). ExamDiff lets you specify a wide range of options that remain in effect over all invocations. Seems like something a lot of users would find natural. Please comment.
> Please submit git-gui patches without the git-gui prefix, as it makes it > harder on the maintainer of git-gui, Shawn (who you did not Cc: BTW).
Sorry Shawn, I should have Cc'd you. Please let me know if I can improve the git-gui code in any way.
-- Keith