git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] git-gui: Prevent double UTF-8 conversion

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Dec 7, 2017, 00:06 UTC
Message-ID
<alpine.DEB.2.21.1.1712070106160.98586@virtualbox>
In-Reply-To
<20171205142326.6140-1-l.stelmach@samsung.com>
Hi Łukasz,
On Tue, 5 Dec 2017, Łukasz Stelmach wrote:
Show 9 quoted lines
> Convert author's name and e-mail address from the UTF-8 (or any other)
> encoding in load_last_commit function the same way commit message is
> converted.
> 
> Amending commits in git-gui without such conversion breaks UTF-8
> strings. For example, "\305\201ukasz" (as written by git cat-file) becomes
> "\303\205\302\201ukasz" in an amended commit.
> 
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
This patch looks good to me.

Thanks, Johannes

Previous: Łukasz StelmachNext: Łukasz Stelmach
Message 7 of 11 in “git-gui: Prevent double UTF-8 conversion”
  1. git-gui: Prevent double UTF-8 conversionŁukasz Stelmach, Nov 28, 2017
  2. Johannes SchindelinNov 28, 2017
  3. Łukasz StelmachDec 2, 2017
  4. git-gui: Prevent double UTF-8 conversionŁukasz Stelmach, Dec 2, 2017
  5. Johannes SchindelinDec 4, 2017
  6. git-gui: Prevent double UTF-8 conversionŁukasz Stelmach, Dec 5, 2017
  7. Johannes SchindelinDec 7, 2017
  8. git-gui: Prevent double UTF-8 conversionŁukasz Stelmach, Dec 14, 2017
  9. Eric SunshineDec 14, 2017
  10. Łukasz StelmachDec 14, 2017
  11. Eric SunshineDec 14, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.