git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-gui: Prevent double UTF-8 conversion

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Nov 28, 2017, 14:35 UTC
Message-ID
<alpine.DEB.2.21.1.1711281524390.6482@virtualbox>
In-Reply-To
<20171128102126.20864-1-l.stelmach@samsung.com>
Hi Łukasz,
On Tue, 28 Nov 2017, Łukasz Stelmach wrote:
> Set encoding to utf-8 for file descriptors used to receive data from git
> commands.

The patch only changes it for the `cat-file` command used to read the latest commit message for amending.

Maybe the commit message should be adjusted to reflect as much?
> With encoding on the file descriptor set to "binary" Tcl (8.6 in my
> case) does double conversion which breaks e.g. author name in amended
> commits.

Is the problem in question occurring when a commit message contains non-ASCII characters encoded in UTF-8 and you click the "Amend Last Commit" radio button on the right side above the "Commit Message" text box?

I tested this with Tcl/Tk 8.6.7-1 of Git for Windows' SDK, and with Tcl/Tk 8.6.0+9 of Ubuntu 16.04.3 LTS, in both cases the encoding of a commit message 'äöü' was handled correctly with "binary"...

Could you give more details about your system so it is easier for me to understand where the difference comes from?

Having said that, I also tested it *with* your patch, and it does not break anything.

> So, this is the second attempt to draw some attention to this patch,
> since the first one has somewhat failed.

Yeah, sadly Pat (who is still listed as the active Git GUI maintainer) has fallen very, very silent for over a year.

Pinging about the status of the patch was definitely the right thing to do.

Ciao, Johannes

Previous: Łukasz StelmachNext: Łukasz Stelmach
Message 2 of 11 in “git-gui: Prevent double UTF-8 conversion”
  1. git-gui: Prevent double UTF-8 conversionŁukasz Stelmach, Nov 28, 2017
  2. Johannes SchindelinNov 28, 2017
  3. Łukasz StelmachDec 2, 2017
  4. git-gui: Prevent double UTF-8 conversionŁukasz Stelmach, Dec 2, 2017
  5. Johannes SchindelinDec 4, 2017
  6. git-gui: Prevent double UTF-8 conversionŁukasz Stelmach, Dec 5, 2017
  7. Johannes SchindelinDec 7, 2017
  8. git-gui: Prevent double UTF-8 conversionŁukasz Stelmach, Dec 14, 2017
  9. Eric SunshineDec 14, 2017
  10. Łukasz StelmachDec 14, 2017
  11. Eric SunshineDec 14, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.