git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] sequencer.c: fix and unify error messages in rearrange_squash()

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Oct 16, 2017, 11:32 UTC
Message-ID
<alpine.DEB.2.21.1.1710161331290.40514@virtualbox>
In-Reply-To
<xmqqfuajuae8.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Mon, 16 Oct 2017, Junio C Hamano wrote:
Show 11 quoted lines
> Ralf Thielow <ralf.thielow@gmail.com> writes:
> 
> > When the write opertion fails, we write that we could
> > not read. Change the error message to match the operation
> > and remove the full stop at the end.
> >
> > When ftruncate() fails, we write that we couldn't finish
> > the operation on the todo file. It is more accurate to write
> > that we couldn't truncate as we do in other calls of ftruncate().
> 
> Wouldn't it be more accurate to say we couldn't ftruncate, though?

This is an end-user facing error message, right? Should we not let users who are happily oblivious of POSIX nomenclature remain happily oblivious?

In other words, I would be finer with "truncate" than with "ftruncate... wait, huh? Is that even English?"

Ciao, Dscho

Previous: Junio C HamanoNext: Philip Oakley
Message 7 of 9 in “sequencer.c: unify error messages”
  1. sequencer.c: unify error messagesRalf Thielow, Oct 13, 2017
  2. René ScharfeOct 13, 2017
  3. Ralf ThielowOct 15, 2017
  4. Johannes SchindelinOct 15, 2017
  5. sequencer.c: fix and unify error messages in rearrange_squash()Ralf Thielow, Oct 15, 2017
  6. Junio C HamanoOct 16, 2017
  7. Johannes SchindelinOct 16, 2017
  8. Philip OakleyOct 16, 2017
  9. Junio C HamanoOct 16, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.