Re: Working with public-inbox.org [Was: [PATCH] rev-parse: respect core.hooksPath in --git-path]

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 13, 2017, 14:37 UTC
Message-ID: <alpine.DEB.2.20.1702131533400.3496@virtualbox>
In-Reply-To: <d16546a4-25be-7b85-3191-e9393fda1164@hotmail.com>

Hi Arif,

On Mon, 13 Feb 2017, Arif Khokar wrote:

Show 28 quoted lines

> On 02/10/2017 11:10 AM, Johannes Schindelin wrote:
> >
> > On Wed, 24 Aug 2016, Johannes Schindelin wrote:
> 
> > > I recently adapted an old script I had to apply an entire patch
> > > series given the GMane link to its cover letter:
> > >
> > > https://github.com/git-for-windows/build-extra/blob/master/apply-from-gmane.sh
> > >
> > > Maybe you find it in you to adapt that to work with
> > > public-inbox.org?
> >
> > Oh well. That would have been too easy a task, right?
> >
> > As it happens, I needed this functionality myself (when reworking my
> > git-path-in-subdir patch to include Mike Rappazzo's previous patch
> > series that tried to fix the same bug).
> >
> > I copy-edited the script to work with public-inbox.org, it accepts a
> > Message-ID or URL or GMane URL and will try to apply the patch (or
> > patch series) on top of the current revision:
> >
> > https://github.com/git-for-windows/build-extra/blob/2268850552c7/apply-from-public-inbox.sh
> 
> Thanks for the link.  One thing that comes to mind that is that it may
> be better to just download the patches and then manually apply them
> afterwords rather than doing it in the script itself.  Or at least add
> an option to the script to not automatically invoke git am.

I actually had expected *you* to put in a little bit of an effort, too. In fact, I was very disappointed that you did not even look into porting that script to use public-inbox instead of GMane.

Show 7 quoted lines

> Getting back to the point I made when this thread was still active, I
> still think it would be better to be able to list the message-id values
> in the header or body of the cover letter message of a patch series
> (preferably the former) in order to facilitate downloading the patches
> via NNTP from gmane or public-inbox.org.  That would make it easier
> compared to the different, ad-hoc, methods that exist for each email
> client.

You can always do that yourself: you can modify your cover letter to include that information.

Note that doing this automatically in format-patch may not be appropriate, as 1) the Message-ID could be modified depending on the mail client used to send the mails, and 2) it is not unheard of that a developer finds a bug in the middle of sending a patch series, fixes that bug, and regenerates the remainder of the patch series, completely rewriting those Message-IDs.

> Alternatively, or perhaps in addition to the list of message-ids, a list
> of URLs to public-inbox.org or gmane messages could also be provided for
> those who prefer to download patches via HTTP.

At this point, I am a little disinterested in a discussion without code. I brought some code to the table, after all.

Ciao, Johannes