git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG/RFC] Git Gui: GIT_DIR leaks to spawned Git Bash

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 18, 2017, 13:04 UTC
Message-ID
<alpine.DEB.2.20.1701181402210.3469@virtualbox>
In-Reply-To
<20170117184224.GA23841@jessie.local>
Hi Max,
On Tue, 17 Jan 2017, Max Kirillov wrote:
Show 7 quoted lines
> On Tue, Jan 17, 2017 at 11:52:29AM +0100, Johannes Schindelin wrote:
> 
> > And having said *that*, I have to admit that I was unable to reproduce
> 
> I have found exact way to reproduce it and actually the reason. Turns
> out to be obvious mistake in code. PR is in github:
> https://github.com/git-for-windows/git/pull/1032

As I pointed out in my review, I think that GIT_DIR is actually only set for `gitk` in the non-submodule case. So I guess if I run Git GUI, spawn gitk, and then Git Bash, it will have GIT_DIR set.

*clicketyclick*
Bingo. That reproduces the problem here.

Thanks, Johannes

Previous: Max Kirillov
Message 4 of 4 in “[BUG/RFC] Git Gui: GIT_DIR leaks to spawned Git Bash”
  1. Max KirillovJan 16, 2017
  2. Johannes SchindelinJan 17, 2017
  3. Max KirillovJan 17, 2017
  4. Johannes SchindelinJan 18, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.