git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG/RFC] Git Gui: GIT_DIR leaks to spawned Git Bash

From
Max Kirillov <max@max630.net>
Date
Jan 17, 2017, 18:42 UTC
Message-ID
<20170117184224.GA23841@jessie.local>
In-Reply-To
<alpine.DEB.2.20.1701171145050.3469@virtualbox>
On Tue, Jan 17, 2017 at 11:52:29AM +0100, Johannes Schindelin wrote:
Show 7 quoted lines
> Hi Max,
> 
> On Tue, 17 Jan 2017, Max Kirillov wrote:
> 
>> Apparently various GIT_* environment variables (most
>> interesting is GIT_DIR but AFAIR there were more) leak to
>> shell session launched from Git Gui's "Git Bash" menu item.
...
> After all, you won't even notice unless you use the very
> same Git Bash to navigate to a *different* worktree.

That's right, I haven't been noticing it myself for quite a time. But once I decided to tweak my habits to having only one terminal window opened, and immediately noticed.

> And having said *that*, I have to admit that I was unable to reproduce

I have found exact way to reproduce it and actually the reason. Turns out to be obvious mistake in code. PR is in github: https://github.com/git-for-windows/git/pull/1032

-- 
Max
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 3 of 4 in “[BUG/RFC] Git Gui: GIT_DIR leaks to spawned Git Bash”
  1. Max KirillovJan 16, 2017
  2. Johannes SchindelinJan 17, 2017
  3. Max KirillovJan 17, 2017
  4. Johannes SchindelinJan 18, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.