Re: [PATCH 1/1] mingw: intercept isatty() to handle /dev/null as Git expects it

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 21, 2016, 17:56 UTC
Message-ID: <alpine.DEB.2.20.1612211854530.155951@virtualbox>
In-Reply-To: <xmqqh963snhs.fsf@gitster.mtv.corp.google.com>

Hi,

On Fri, 16 Dec 2016, Junio C Hamano wrote:

Show 15 quoted lines

> Johannes Sixt <j6t@kdbg.org> writes:
> 
> > Am 16.12.2016 um 19:08 schrieb Junio C Hamano:
> >> Sorry for not having waited for you to chime in before agreeing to
> >> fast-track this one, and now this is in 'master'.
> >
> > No reason to be sorry, things happen... Dscho's request for
> > fast-tracking was very reasonable, and the patch looked "obviously
> > correct".
> 
> Oh, I do agree it was reasonable and looked obviously correct.  And
> I suspect that it did not make anything worse, either, so there is
> not much harm done, other than that I now have to remember not to
> merge it down without further fixes to 'maint' and declare the NUL
> thing fixed ;-)

Actually, due to having way too many worktrees I managed to test the exact wrong build product and failed to notice that the patch I asked to fast-track broke paging in Git for Windows' Git Bash, too, not only in CMD.

Bummer.

> > Unfortunately, I'm away from my Windows box over the weekend. It will
> > have to wait until Monday before I can test this idea.
> 
> Thanks.

I just sent out a fixer-upper patch series, hopefully I got it right this time.

Hannes, it would be very nice if you could beat on it for a bit.

Happy holidays, Dscho