Re: [PATCH 0/1] Fix a long-standing isatty() problem on Windows

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 12, 2016, 09:59 UTC
Message-ID: <alpine.DEB.2.20.1612121052310.23160@virtualbox>
In-Reply-To: <xmqqmvg2nyo6.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Sun, 11 Dec 2016, Junio C Hamano wrote:

Show 10 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > I finally got a chance to debug the problems with the ever-timing-out
> > test runs of `pu` on Windows. Turns out that pb/bisect uncovered a
> > really old, really bad bug: on Windows, isatty() does not do what Git
> > expects, at least not completely: it detects interactive terminals *and
> > character devices*.
> 
> Sounds as if somebody who did Windows at Microsoft had a good sense
> of humor to mimick the misnamed ENOTTY gotcha ;-)

Hehe...

> This is a great find, and a very impactful fix, as redirecting from
> /dev/null is how we try to force a "go interactive if talking to
> tty" program to realize that it is not talking to a tty.

Can we fast-track this to maint?

I will definitely ship this fix in the next Git for Windows version, but still, it would be nice to have this in git.git as soon as possible.

Thanks, Dscho