Re: What's cooking in git.git (Dec 2016, #02; Mon, 12)
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Dec 13, 2016, 15:39 UTC
- Message-ID
- <alpine.DEB.2.20.1612131638290.23160@virtualbox>
- In-Reply-To
- <xmqqoa0g96o3.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Mon, 12 Dec 2016, Junio C Hamano wrote:
Show 8 quoted lines
> * js/mingw-isatty (2016-12-11) 1 commit > (merged to 'next' on 2016-12-12 at 60c1da6676) > + mingw: intercept isatty() to handle /dev/null as Git expects it > > We often decide if a session is interactive by checking if the > standard I/O streams are connected to a TTY, but isatty() emulation > on Windows incorrectly returned true if it is used on NUL (i.e. an > equivalent to /dev/null). This has been fixed.
I'd like to suggest a reword: we did not use an isatty() emulation, but Windows' own _isatty() function that simply has different semantics than what Git expected. *Now* we have an isatty() emulation that wraps _isatty() and emulates the behavior expected by Git.
Thanks, Dscho