Re: What's cooking in git.git (Dec 2016, #02; Mon, 12)

From: Brandon Williams <bmwill@google.com>
Date: Dec 13, 2016, 21:37 UTC
Message-ID: <20161213213706.GA4121@google.com>
In-Reply-To: <xmqqeg1b39yi.fsf@gitster.mtv.corp.google.com>

On 12/13, Junio C Hamano wrote:

Show 25 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > ok 13 - grep tree and more pathspecs
> >
> > expecting success: 
> > 	git init parent &&
> > 	test_when_finished "rm -rf parent" &&
> > 	echo "foobar" >"parent/fi:le" &&
> > 	git -C parent add "fi:le" &&
> > 	git -C parent commit -m "add fi:le" &&
> > ...
> > 	test_cmp expect actual
> >
> > ++ git init parent
> > Initialized empty Git repository in C:/git-sdk-64/usr/src/git/wip3/t/trash
> > directory.t7814-grep-recurse-submodules/parent/.git/
> > ++ test_when_finished 'rm -rf parent'
> > ++ test 0 = 0
> > ++ test_cleanup='{ rm -rf parent
> > 		} && (exit "$eval_ret"); eval_ret=$?; :'
> > ++ echo foobar
> > ++ git -C parent add fi:le
> > fatal: pathspec 'fi:le' did not match any files
> 
> I think !MINGW prereq is missing?

Yes the !MINGW prereq is missing on this one test since the test uses a filename with a ":" which isn't supported on windows. I have that change made in my local grep branch but I haven't sent out a reroll of the series yet due to the underlying race-condition that existed (due to the way realpath was being calculated). I'll send out a reroll of the series once the discussion on bw/realpath-wo-chdir has concluded (as the grep series is now dependent on it).

-- 
Brandon Williams