Re: [PATCH] convert: mark a file-local symbol static

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 17, 2016, 09:04 UTC
Message-ID: <alpine.DEB.2.20.1610171058580.197091@virtualbox>
In-Reply-To: <20161017021825.jgpsew7qqfjrirhw@sigill.intra.peff.net>

Hi Ramsay & Peff,

On Sun, 16 Oct 2016, Jeff King wrote:

Show 13 quoted lines

> On Mon, Oct 17, 2016 at 02:37:58AM +0100, Ramsay Jones wrote:
> 
> > Hmm, well, you have to remember that 'make clean' sometimes doesn't
> > make clean. Ever since the Makefile was changed to only remove
> > $(OBJECTS), rather than *.o xdiff/*.o etc., you have to remember to
> > 'make clean' _before_ you switch branches. Otherwise, you risk leaving
> > some objects laying around. Since the script runs 'nm' on all objects
> > it finds, any stale ones can cause problems.  (Of course, I almost
> > always forget, so I frequently have to manually check for and remove
> > stale objects!)
> 
> Gross. I would not be opposed to a Makefile rule that outputs the
> correct set of OBJECTS so this (or other) scripts could build on it.

You could also use the method I use in Git for Windows to "extend" the Makefile:

-- snipsnap -- cat >dummy.mak <<EOF include Makefile

blub: $(OBJECTS)
	do-something-with $^
EOF

make -f dummy.mak blub