git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] convert: mark a file-local symbol static

From
Lars Schneider <larsxschneider@gmail.com>
Date
Oct 16, 2016, 00:15 UTC
Message-ID
<B7662EA0-3181-413E-A40B-69C88FC46F96@gmail.com>
In-Reply-To
<de24ed05-2857-9c17-920f-66770f898f80@ramsayjones.plus.com>
Show 17 quoted lines
> On 15 Oct 2016, at 14:01, Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:
> 
> 
> 
> On 15/10/16 16:05, Lars Schneider wrote:
>>> On 11 Oct 2016, at 16:46, Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:
> [snip]
>>> -void stop_multi_file_filter(struct child_process *process)
>>> +static void stop_multi_file_filter(struct child_process *process)
>> 
>> Done! Do you have some kind of script to detect these things
>> automatically or do you read the code that carefully?
> 
> Heh, I'm _far_ too lazy to read the code that carefully. :-D
> 
> A combination of 'make sparse' and a perl script (originally
> posted to the list by Junio) find all of these for me.

Interesting. Do you have a link to this script? Does it generate false positives? Maybe I can add `make sparse` to the TravisCI build?

Cheers, Lars

Previous: Ramsay JonesNext: Ramsay Jones
Message 4 of 14 in “convert: mark a file-local symbol static”
  1. convert: mark a file-local symbol staticRamsay Jones, Oct 11, 2016
  2. Lars SchneiderOct 15, 2016
  3. Ramsay JonesOct 15, 2016
  4. Lars SchneiderOct 16, 2016
  5. Ramsay JonesOct 17, 2016
  6. Jeff KingOct 17, 2016
  7. Johannes SchindelinOct 17, 2016
  8. Jeff KingOct 17, 2016
  9. Ramsay JonesOct 17, 2016
  10. Junio C HamanoOct 17, 2016
  11. René ScharfeOct 17, 2016
  12. Stefan BellerOct 17, 2016
  13. Ramsay JonesOct 17, 2016
  14. Ramsay JonesOct 17, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.