Re: [PATCH 01/20] cache: convert struct cache_entry to use struct object_id
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Aug 29, 2016, 10:50 UTC
- Message-ID
- <alpine.DEB.2.20.1608291249230.129229@virtualbox>
- In-Reply-To
- <20160828232757.373278-2-sandals@crustytoothpaste.net>
Hi Brian,
On Sun, 28 Aug 2016, brian m. carlson wrote:
Show 16 quoted lines
> Convert struct cache_entry to use struct object_id by applying the > following semantic patch and the object_id transforms from contrib: > > @@ > struct cache_entry E1; > @@ > - E1.sha1 > + E1.oid.hash > > @@ > struct cache_entry *E1; > @@ > - E1->sha1 > + E1->oid.hash > > Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Makes sense, iff you find:
Show 12 quoted lines
> diff --git a/cache.h b/cache.h
> index b780a91a..a679484e 100644
> --- a/cache.h
> +++ b/cache.h
> @@ -173,7 +173,7 @@ struct cache_entry {
> unsigned int ce_flags;
> unsigned int ce_namelen;
> unsigned int index; /* for link extension */
> - unsigned char sha1[20];
> + struct object_id oid;
> char name[FLEX_ARRAY]; /* more */
> };(which is unfortunately buried deep in the diff...)
Ciao, Dscho