Re: [PATCH] t/Makefile: make sure that file names are truly platform-independent
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Aug 16, 2016, 15:10 UTC
- Message-ID
- <alpine.DEB.2.20.1608161710100.4924@virtualbox>
- In-Reply-To
- <xmqqinv1do2d.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Tue, 16 Aug 2016, Junio C Hamano wrote:
Show 18 quoted lines
> Junio C Hamano <gitster@pobox.com> writes: > > > The trick to catch non-ascii depends on core.quotepath set to true > > (which is the default). You would need to run ls-files with an > > explicit "-c core.quotepath=false" to be safe. > > ... > > The invocation of "git -c core.quotepath=false ls-files" needs to at > > least have 2>/dev/null to squelch an unnecessary error message. In > > such a scenario, we may miss a new offending pathname, but we will > > not have false positive and I think that is the best we can do. > > > > Thanks. > > Needless to say (1) both "false" should have been "true"; (2) I > shouldn't be crawling out of bed and typing with hazy brain early in > the morning. > > Sorry for typoes and thinkos.
Sorry for not even expecting an answer from you that early. I will send out a v3 in a moment that should address your concerns.
Ciao, Dscho