[PATCH] t/Makefile: make sure that file names are truly platform-independent
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Aug 15, 2016, 14:08 UTC
- Message-ID
- <814aefbcf0f9380098e3f7a183399e11e24180dd.1471270061.git.johannes.schindelin@gmx.de>
Some file names that are okay on ext4 and on HFS+ are illegal in Windows. In order to stay truly platform-independent, Git's source code must not contain such illegal file names, even if things just happen to work on Linux.
One such file name was recently introduced into Git's `pu` branch:
t4013/diff.diff_--diff-line-prefix=-->_master_master^_sidt4013/diff.diff_--diff-line-prefix=-->_master_master^_sid
It is illegal because it contains the '>' character that is not part of a valid filename on Windows.
To catch these issues early, let's introduce a new test-lint-* goal that fails if such file names were detected and run it as part of a `make test`.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- Published-As: https://github.com/dscho/git/releases/tag/test-lint-filenames-v1 Fetch-It-Via: git fetch https://github.com/dscho/git test-lint-filenames-v1
This is the more complete fix I talked about.
t/Makefile | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/t/Makefile b/t/Makefile index 18e2b28..3c0eb48 100644 --- a/t/Makefile +++ b/t/Makefile @@ -52,7 +52,8 @@ clean-except-prove-cache: clean: clean-except-prove-cache $(RM) .prove -test-lint: test-lint-duplicates test-lint-executable test-lint-shell-syntax +test-lint: test-lint-duplicates test-lint-executable test-lint-shell-syntax \ + test-lint-filenames test-lint-duplicates: @dups=`echo $(T) | tr ' ' '\n' | sed 's/-.*//' | sort | uniq -d` && \ @@ -67,6 +68,11 @@ test-lint-executable: test-lint-shell-syntax: @'$(PERL_PATH_SQ)' check-non-portable-shell.pl $(T) $(THELPERS) +test-lint-filenames: + @illegal="$$(git ls-files | grep '["*:<>?\\|]')"; \ + test -z "$$illegal" || { \ + echo >&2 "illegal file name(s): " $$illegal; exit 1; } + aggregate-results-and-cleanup: $(T) $(MAKE) aggregate-results $(MAKE) clean
-- 2.9.2.691.g78954f3 base-commit: 5e18482599a6cfeb8d4e0ee5a98d30220cbdff72