Re: [PATCH] git-clean: remove fifo, devices, socket files
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jul 15, 2016, 10:48 UTC
- Message-ID
- <alpine.DEB.2.20.1607151246190.6426@virtualbox>
- In-Reply-To
- <CANaxB-y6XW7-ps1G2CB=N9CiD0VnSLhSer2nsf+2R4pm5TyswA@mail.gmail.com>
Hi Andrey,
On Fri, 15 Jul 2016, Andrey Vagin wrote:
> What will be wrong if 'git status' will reports these [fifo/socket] files?
`git status` is intended to give you an idea what to commit next. And...
> What will be wrong if 'git add' will returns an error instead of > skipping them silently?
... we *cannot* commit fifos or sockets. There is simply no representation in Git's data model for them.
Having said that, I would welcome a patch that makes `git add` complain about arguments that could not be added (and are not directories).
As to the patch in question, for the above-mentioned reasons, I think we want to keep the existing behavior instead.
Ciao, Johannes