Re: [PATCH] git-clean: remove fifo, devices, socket files

From: Johannes Sixt <j6t@kdbg.org>
Date: Jul 15, 2016, 20:33 UTC
Message-ID: <3a6cb604-daa0-6d34-3342-0671a0b23032@kdbg.org>
In-Reply-To: <CANaxB-y6XW7-ps1G2CB=N9CiD0VnSLhSer2nsf+2R4pm5TyswA@mail.gmail.com>

Am 15.07.2016 um 09:46 schrieb Andrey Vagin:

Show 11 quoted lines

> On Thu, Jul 14, 2016 at 10:56 PM, Johannes Sixt <j6t@kdbg.org> wrote:
>> IOW: These special files are invisible for Git unless it already knows the
>> names. The latter case is outside 'git clean's domain, and the former case
>> really means that special files in the working tree are left at the user's
>> discretion.
>
> I understand your points, but I don't see any reasons to ignore these files.
>
> What will be wrong if 'git status' will reports these files?
> What will be wrong if 'git add' will returns an error instead of
> skipping them silently?

I can buy that 'git add' reports an error for special files. (And I concur with Dscho that the behavior should otherwise remain unchanged.) But this is not what the commit message sells even if the patch changes the behavior of 'git add', too (I haven't tested the patch).

-- Hannes