git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] regex: fix a SIZE_MAX macro redefinition warning

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jun 5, 2016, 07:15 UTC
Message-ID
<alpine.DEB.2.20.1606050815360.4250@virtualbox>
In-Reply-To
<575212DF.90209@ramsayjones.plus.com>
Hi Ramsay,
thanks for working on this!
On Sat, 4 Jun 2016, Ramsay Jones wrote:
Show 10 quoted lines
> diff --git a/Makefile b/Makefile
> index 0d59718..3f6c70a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1987,7 +1987,7 @@ endif
>  
>  ifdef NO_REGEX
>  compat/regex/regex.sp compat/regex/regex.o: EXTRA_CPPFLAGS = \
> -	-DGAWK -DNO_MBSUPPORT
> +	-DGAWK -DNO_MBSUPPORT -DHAVE_STDINT_H

Maybe a comment here, something like "the fallback regex implementation *requires* stdint.h"?

Other than that, I think this patch is an improvement.

Thanks again, Dscho

Previous: Ramsay JonesNext: Ramsay Jones
Message 2 of 5 in “regex: fix a SIZE_MAX macro redefinition warning”
  1. regex: fix a SIZE_MAX macro redefinition warningRamsay Jones, Jun 3, 2016
  2. Johannes SchindelinJun 5, 2016
  3. Ramsay JonesJun 5, 2016
  4. Johannes SchindelinJun 6, 2016
  5. Junio C HamanoJun 6, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.