From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 05 Jun 2016 07:15:27 GMT
Subject: Re: [PATCH] regex: fix a SIZE_MAX macro redefinition warning
Message-ID: <alpine.DEB.2.20.1606050815360.4250@virtualbox>
In-Reply-To: <575212DF.90209@ramsayjones.plus.com>

Hi Ramsay,

thanks for working on this!

On Sat, 4 Jun 2016, Ramsay Jones wrote:

> diff --git a/Makefile b/Makefile
> index 0d59718..3f6c70a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1987,7 +1987,7 @@ endif
>  
>  ifdef NO_REGEX
>  compat/regex/regex.sp compat/regex/regex.o: EXTRA_CPPFLAGS = \
> -	-DGAWK -DNO_MBSUPPORT
> +	-DGAWK -DNO_MBSUPPORT -DHAVE_STDINT_H

Maybe a comment here, something like "the fallback regex implementation
*requires* stdint.h"?

Other than that, I think this patch is an improvement.

Thanks again,
Dscho