Re: [PATCH 2/3] mmap(win32): avoid copy-on-write when it is unnecessary
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Apr 28, 2016, 08:03 UTC
- Message-ID
- <alpine.DEB.2.20.1604281001220.2896@virtualbox>
- In-Reply-To
- <57210A38.4080203@kdbg.org>
Hi Hannes,
On Wed, 27 Apr 2016, Johannes Sixt wrote:
Show 14 quoted lines
> Am 27.04.2016 um 08:43 schrieb Johannes Schindelin:
> > On Tue, 26 Apr 2016, Johannes Sixt wrote:
> > > Should we insert a check for MAP_PRIVATE to catch
> > > unexpected use-cases (think of the index-helper daemon effort)?
> >
> > I agree, we should have such a check. The line above the `die("Invalid
> > usage ...")` that you can read as first line in above-quoted hunk reads:
> >
> > if (!(flags & MAP_PRIVATE))
> >
> > So I think we're fine :-)
>
> Oh, well... I thought I had checked the code before I wrote my question, but
> it seems I was blind... ;)Don't worry! I really appreciate your review!
Ciao, Johannes