git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] mmap(win32): avoid copy-on-write when it is unnecessary

From
Johannes Sixt <j6t@kdbg.org>
Date
Apr 27, 2016, 18:51 UTC
Message-ID
<57210A38.4080203@kdbg.org>
In-Reply-To
<alpine.DEB.2.20.1604270834440.2896@virtualbox>
Am 27.04.2016 um 08:43 schrieb Johannes Schindelin:
Show 10 quoted lines
> On Tue, 26 Apr 2016, Johannes Sixt wrote:
>> Should we insert a check for MAP_PRIVATE to catch
>> unexpected use-cases (think of the index-helper daemon effort)?
>
> I agree, we should have such a check. The line above the `die("Invalid
> usage ...")` that you can read as first line in above-quoted hunk reads:
>
> 	if (!(flags & MAP_PRIVATE))
>
> So I think we're fine :-)

Oh, well... I thought I had checked the code before I wrote my question, but it seems I was blind... ;)

Thanks, -- Hannes

Previous: Johannes SchindelinNext: Johannes Schindelin
Message 6 of 8 in “Improve the mmap() emulation on Windows”
  1. 0/3 Improve the mmap() emulation on WindowsJohannes Schindelin, Apr 22, 2016
  2. 1/3 win32mmap: set errno appropriatelyJohannes Schindelin, Apr 22, 2016
  3. 2/3 mmap(win32): avoid copy-on-write when it is unnecessaryJohannes Schindelin, Apr 22, 2016
  4. Johannes SixtApr 26, 2016
  5. Johannes SchindelinApr 27, 2016
  6. Johannes SixtApr 27, 2016
  7. Johannes SchindelinApr 28, 2016
  8. 3/3 mmap(win32): avoid expensive fstat() callJohannes Schindelin, Apr 22, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.