Re: [PATCH] compat/mingw: brown paper bag fix for 50a6c8e

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 1, 2016, 13:52 UTC
Message-ID: <alpine.DEB.2.20.1603011452090.3152@virtualbox>
In-Reply-To: <20160301055457.GA1359@sigill.intra.peff.net>

Hi Peff,

On Tue, 1 Mar 2016, Jeff King wrote:

Show 11 quoted lines

> On Tue, Mar 01, 2016 at 06:49:43AM +0100, Torsten Bögershausen wrote:
> 
> > However, suspecting jk/epipe-in-async, I don't know if we can do
> > something against this warning:
> > 
> >  CC run-command.o run-command.c: In function 'async_exit':
> >  run-command.c:631:1: warning: 'noreturn' function does return } ^
> 
> The only thing that function does is call pthread_exit(), which should
> also be marked NORETURN. Looks like the one in compat/win32/pthread.h
> isn't?

Correct. Expect a patch momentarily.

Ciao, Dscho