git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] compat/mingw: brown paper bag fix for 50a6c8e

From
Jeff King <peff@peff.net>
Date
Feb 29, 2016, 21:36 UTC
Message-ID
<20160229213620.GD25342@sigill.intra.peff.net>
In-Reply-To
<xmqqtwkr9vu6.fsf@gitster.mtv.corp.google.com>
On Mon, Feb 29, 2016 at 11:10:09AM -0800, Junio C Hamano wrote:
Show 18 quoted lines
> >> -       wargs = xmalloc_array(st_add(st_mult(2, args.len), 1), sizeof(wchar_t));
> >> +       wargs = ALLOC_ARRAY(st_add(st_mult(2, args.len), 1), sizeof(wchar_t));
> >>         xutftowcs(wargs, args.buf, 2 * args.len + 1);
> >>         strbuf_release(&args);
> >
> > Argh. Let me write "git commit -a" on the inside of my brown paper bag,
> > so that I actually send out the fix sitting in my working tree, not the
> > half-finished thing I ran "git add" on.
> 
> Just to make sure that I am not confused, what you wrote below
> matches what I received from you two message upthread.
> 
> I am assuming that it is intended that the two messages from you
> have the same patch, and the assignment of ALLOC_ARRAY to wargs was
> a bug Torsten introduced only to his tree when cutting and pasting.
> 
> With that assumption, will queue this one (or the original one,
> which to me is the same thing).
Oh, <phew>. I am only half as incompetent as I thought, then.

I didn't even re-check what I sent, and just assumed Torsten was quoting it exactly (I _did_ write something like that while making the fix, and assumed I had just failed to properly commit).

So yes, what I sent both times is the right thing. ;)
-Peff
Previous: Junio C HamanoNext: Torsten Bögershausen
Message 14 of 18 in “50a6c8ef - xmalloc_array”
  1. Torsten BögershausenFeb 29, 2016
  2. compat/mingw: brown paper bag fix for 50a6c8eJeff King, Feb 29, 2016
  3. Torsten BögershausenFeb 29, 2016
  4. Jeff KingFeb 29, 2016
  5. Compiler warning under cygwin/mingw (was: fix for 50a6c8e)Torsten Bögershausen, Feb 29, 2016
  6. Jeff KingFeb 29, 2016
  7. SZEDER GáborFeb 29, 2016
  8. Junio C HamanoApr 12, 2016
  9. Junio C HamanoMay 10, 2016
  10. Ramsay JonesFeb 29, 2016
  11. Ramsay JonesMar 3, 2016
  12. Ramsay JonesMar 3, 2016
  13. Junio C HamanoFeb 29, 2016
  14. Jeff KingFeb 29, 2016
  15. Torsten BögershausenMar 1, 2016
  16. Jeff KingMar 1, 2016
  17. Johannes SchindelinMar 1, 2016
  18. Johannes SchindelinFeb 29, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.