git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] test-path-utils: use xsnprintf in favor of strcpy

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 19, 2016, 11:05 UTC
Message-ID
<alpine.DEB.2.20.1601191041260.2964@virtualbox>
In-Reply-To
<20160115183010.GA10431@sigill.intra.peff.net>
Hi Peff,
On Fri, 15 Jan 2016, Jeff King wrote:
Show 21 quoted lines
> On Fri, Jan 15, 2016 at 07:45:16AM +0100, Johannes Schindelin wrote:
> 
> > > This sort-of applies on top of js/dirname-basename, which is in next.
> > > Textually, it's fine, but that topic is based on v2.6.5, and xsnprintf
> > > was only added in the v2.7.0 cycle. The simplest thing is probably to
> > > wait for it to graduate to master, and then apply there as a new topic
> > > (if we do v2.6.6, it's OK for it not to have this patch).
> > > 
> > > I can hold and resend in a week or two if that's easier.
> > 
> > If you have a patch to make dirname/basename safer based on xsnprintf, I
> > would like to have that as soon as possible (next was rewound to 2.7.0,
> > no?)...
> 
> I'm not sure what you mean. `dirname/basename` themselves don't have any
> problems. It's only the `strcpy` in the test program that I wanted to
> fix.
> 
> If Junio wants to rebase js/dirname-basename on a more recent tip (say,
> current "master") as part of the rewind, this could be applied directly
> (or just squashed in).
My bad... I misunderstood which code was affected.

Sorry for the noise, Dscho

Previous: Jeff King
Message 4 of 4 in “test-path-utils: use xsnprintf in favor of strcpy”
  1. test-path-utils: use xsnprintf in favor of strcpyJeff King, Jan 14, 2016
  2. Johannes SchindelinJan 15, 2016
  3. Jeff KingJan 15, 2016
  4. Johannes SchindelinJan 19, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.