Re: [PATCH] test-path-utils: use xsnprintf in favor of strcpy

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 15, 2016, 06:45 UTC
Message-ID: <alpine.DEB.2.20.1601150743590.2964@virtualbox>
In-Reply-To: <20160114202608.GA8806@sigill.intra.peff.net>

Hi Peff,

On Thu, 14 Jan 2016, Jeff King wrote:

> This strcpy will never overflow because it's copying from
> baked-in test data. But we would prefer to avoid strcpy
> entirely, as it makes it harder to audit for real security
> bugs.

Thanks.

Show 7 quoted lines

> This sort-of applies on top of js/dirname-basename, which is in next.
> Textually, it's fine, but that topic is based on v2.6.5, and xsnprintf
> was only added in the v2.7.0 cycle. The simplest thing is probably to
> wait for it to graduate to master, and then apply there as a new topic
> (if we do v2.6.6, it's OK for it not to have this patch).
> 
> I can hold and resend in a week or two if that's easier.

If you have a patch to make dirname/basename safer based on xsnprintf, I would like to have that as soon as possible (next was rewound to 2.7.0, no?)...

Thanks! Dscho