Re: [RFC/PATCH git] http: avoid empty error messages for some curl errors

From: Daniel Stenberg <daniel@haxx.se>
Date: Sep 6, 2011, 18:00 UTC
Message-ID: <alpine.DEB.2.00.1109061957120.29735@tvnag.unkk.fr>
In-Reply-To: <7v62l5a9ke.fsf@alter.siamese.dyndns.org>

On Tue, 6 Sep 2011, Junio C Hamano wrote:

Show 12 quoted lines

>>
>> For the record, in libcurl we work on providing "extra" information in
>> the error buffer when there is additional info to provide that would
>> help. In some cases we deem there isn't (or we just to provide any)
>> and then the generic error message is good enough and could indeed be
>> used like this...
>
> Sorry if I am a bit slow but are you saying:
>
> (1) we provide "extra" but your patch is not using it which is bad?
> (2) the above is Ok but there are better ways to do it?
> (3) something else?

Sorry for being unclear.

I was trying to explain why the proposed patch makes sense and that it will continue to make sense even if in future libcurl versions it would start returning error messages for errors where currently it returns none.

Thus, I am in favour of the general idea of the patch - I have no comment for the exact implementation as I haven't checked the details.

-- 
  / daniel.haxx.se