git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH git] http: avoid empty error messages for some curl errors

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 6, 2011, 22:49 UTC
Message-ID
<7vehzt70c1.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20110905222202.GA32071@elie>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 21 quoted lines
> When asked to fetch over SSL without a valid
> /etc/ssl/certs/ca-certificates.crt file, "git fetch" writes
>
> 	error:  while accessing https://github.com/torvalds/linux.git/info/refs
>
> which is a little disconcerting.  Better to fall back to
> curl_easy_strerror(result) when the error string is empty, like the
> curl utility does:
>
> 	error: Problem with the SSL CA cert (path? access rights?) while
> 	accessing https://github.com/torvalds/linux.git/info/refs
>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> ---
> Hi,
>
> I ran into this error today because this machine has no certs enabled.
> I'm not thrilled with the following patch because the error string
> buffer is not cleared very often so it seems possible for it to be
> not empty but stale at the relevant moment.  I would be happier if we
> could rely on libcurl always filling the error buffer on errors.
Will queue both patches; thanks.
Previous: Daniel Stenberg
Message 6 of 6 in “http: avoid empty error messages for some curl errors”
  1. http: avoid empty error messages for some curl errorsJonathan Nieder, Sep 5, 2011
  2. http: remove extra newline in error messageJonathan Nieder, Sep 5, 2011
  3. Daniel StenbergSep 6, 2011
  4. Junio C HamanoSep 6, 2011
  5. Daniel StenbergSep 6, 2011
  6. Junio C HamanoSep 6, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.