Re: [PATCH] Allow git to use any HTTP authentication method.

From: Martin Storsjö <martin@martin.st>
Date: Dec 28, 2009, 15:50 UTC
Message-ID: <alpine.DEB.2.00.0912281745540.5582@cone.home.martin.st>
In-Reply-To: <20091228153701.GA2252@spearce.org>

On Mon, 28 Dec 2009, Shawn O. Pearce wrote:

Show 12 quoted lines

> Uh, stupid question, but why must we enable this option?  I don't
> have to enable something in my browser before I use digest auth to
> visit a website, why do I need to enable it in git?
> 
> How does one use git clone with an http:// URL with digest
> authentication?  Its not obvious to the user that you would need
> to first export an obtuse environment variable to get something
> that should Just Work(tm).
> 
> Yes, I realize you may need to perform an extra HTTP request to
> start the transaction, but why aren't we doing that?  Isn't it only
> 1 additional request to discover the desired authentication method?

Initially when I added support for this, curl sessions weren't reused, so every single request had to be duplicated if authentication was used, adding quite a bit of overhead.

Now that sessions are reused properly, I tend to agree that this should be enabled automatically.

Any other opinions on this, Tay or Junio?

Should I send in a new patch that removes the http.authAny option and always enables this, or send a rewritten version of the patch that already is in 'next'?

// Martin