Re: [PATCH] Allow git to use any HTTP authentication method.
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Dec 28, 2009, 15:53 UTC
- Message-ID
- <20091228155346.GB2252@spearce.org>
- In-Reply-To
- <alpine.DEB.2.00.0912281745540.5582@cone.home.martin.st>
Martin Storsj? <martin@martin.st> wrote:
Show 6 quoted lines
> Initially when I added support for this, curl sessions weren't reused, so > every single request had to be duplicated if authentication was used, > adding quite a bit of overhead. > > Now that sessions are reused properly, I tend to agree that this should be > enabled automatically.
Oh, that makes sense, thanks for the explanation.
> Should I send in a new patch that removes the http.authAny option and > always enables this, or send a rewritten version of the patch that already > is in 'next'?
I'm not Junio, but I would suggest sending in a new patch series, and asking Junio politely to revert the one that is currently in next before merging in the new series.
If we really are killing http.authAny before it hits master, there is no reason for it to appear in the final project history.
-- Shawn.