Re: [PATCH v2] bisect reset: Allow resetting to any commit, not just a branch

From: Anders Kaseorg <andersk@mit.edu>
Date: Oct 13, 2009, 20:09 UTC
Message-ID: <alpine.DEB.2.00.0910131605170.5105@dr-wily.mit.edu>
In-Reply-To: <200910132206.18460.chriscool@tuxfamily.org>

On Tue, 13 Oct 2009, Christian Couder wrote:

Show 9 quoted lines

> +       1) git rev-parse --quiet --verify "$1^{commit}" > /dev/null ||
> +               die "'$1' does not seem to point to a valid commit"
> 
> It would give a better error message when "git rev-parse" fails instead of:
> 
> fatal: Needed a single revision
> 
> and it would not print the SHA1 from "$1^{commit}" when "git rev-parse" 
> succeeds.

Oh, oops, I somehow lost the > /dev/null in my version.

But as for the ‘git rev-parse’ error being confusing, why don’t we fix ‘git rev-parse’ instead?

Anders