Re: [PATCH v2] bisect reset: Allow resetting to any commit, not just a branch

From: Christian Couder <chriscool@tuxfamily.org>
Date: Oct 13, 2009, 20:30 UTC
Message-ID: <200910132230.04498.chriscool@tuxfamily.org>
In-Reply-To: <alpine.DEB.2.00.0910131605170.5105@dr-wily.mit.edu>

On Tuesday 13 October 2009, Anders Kaseorg wrote:

Show 16 quoted lines

> On Tue, 13 Oct 2009, Christian Couder wrote:
> > +       1) git rev-parse --quiet --verify "$1^{commit}" > /dev/null ||
> > +               die "'$1' does not seem to point to a valid commit"
> >
> > It would give a better error message when "git rev-parse" fails instead
> > of:
> >
> > fatal: Needed a single revision
> >
> > and it would not print the SHA1 from "$1^{commit}" when "git rev-parse"
> > succeeds.
>
> Oh, oops, I somehow lost the > /dev/null in my version.
>
> But as for the ‘git rev-parse’ error being confusing, why don’t we fix
> ‘git rev-parse’ instead?

It's a plumbing command, and the output of plumbing commands is not supposed to change a lot as some scripts may rely on it.

And anyway that would be in another patch.

Best regards, Christian.