Re: [PATCH] http-push: refactor request url creation

From: Daniel Stenberg <daniel@haxx.se>
Date: Jan 26, 2009, 08:02 UTC
Message-ID: <alpine.DEB.1.10.0901260901320.32450@yvahk2.pbagnpgbe.fr>
In-Reply-To: <be6fef0d0901251752p5b34c053pb24dce8a35b06fce@mail.gmail.com>

On Mon, 26 Jan 2009, Ray Chuan wrote:

Show 8 quoted lines

>>> -     curl_easy_setopt(slot->curl, CURLOPT_URL, url);
>>> +     curl_easy_setopt(slot->curl, CURLOPT_URL, request->url);
>>
>> The original code gave a separate "url" to setop() but this gives the same
>> string.  Does curl_easy_setop() copies the given string away?  IOW is this
>> change safe?
>
> curl strdup's it, so this is safe.

I'm not sure what the oldest possibly libcurl version git can deal with, but here's a related quote from the curl_easy_setopt man page:

        NOTE: before 7.17.0 strings were  not  copied.  Instead  the  user  was
        forced keep them available until libcurl no longer needed them.

-- 
  / daniel.haxx.se