Re: [PATCH] http-push: refactor request url creation
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 27, 2009, 04:58 UTC
- Message-ID
- <7vskn51h1l.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <alpine.DEB.1.00.0901261141070.14855@racer>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> curl strdup's it, so this is safe. > > I might have mentioned that things like this _need_ to go into the commit > message.
Yeah, and let's not forget advice from Daniel Stenberg.
I'm not sure what the oldest possibly libcurl version git can deal
with, but here's a related quote from the curl_easy_setopt man page: NOTE: before 7.17.0 strings were not copied. Instead the user was
forced keep them available until libcurl no longer needed them.