git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC] Adding a challenge-response authentication method to git://

From
Ddavid@lang.hm <david@lang.hm>
Date
Aug 14, 2008, 17:24 UTC
Message-ID
<alpine.DEB.1.10.0808141021210.13400@asgard.lang.hm>
In-Reply-To
<48A3F7AA.8070001@op5.se>
On Thu, 14 Aug 2008, Andreas Ericsson wrote:
Show 23 quoted lines
> I'd do it like this instead:
>
> daemon: auth_user = dlsym(dlopen("auth-module.so", RTLD_NOW), "authenticat");
> client: "git-authenticate action 'repository'"
> daemon: send pkt-line challenge
> client: send pkt-line username
> client: send pkt-line SHA1(username + password + challenge)
> daemon: if (auth_user(repository, action, username, password, struct 
> sockaddr_in *inbound))
>              allow_connection();
>
> This approach has several nifty benefits:
> * The otherwise duplicated code (for different auth schemes) is
> done only once (in the git daemon).
> * If the git daemon has no authentication module loaded, we might
> as well not bother sending any challenge and just pretend we do
> not know about the authentication scheme.
> * Any kind of authentication scheme can be supported without changing
> the core code. If the authentication module does something wrong,
> one can continue to serve read-only requests by simply unloading
> the module.
> * Modules is a great way for newcomers to get started contributing to
> git so it's a nice way of getting more contributors/sub-maintainers.

if you're going to do modules, you should give the module the connection until it's done so that different types of authentication can be implemented by the module.

David Lang
Previous: Stephen R. van den BergNext: david@lang.hm
Message 16 of 18 in “[RFC] Adding a challenge-response authentication method to git://”
  1. Stephen R. van den BergAug 13, 2008
  2. Petr BaudisAug 13, 2008
  3. David BrownAug 14, 2008
  4. Petr BaudisAug 14, 2008
  5. Stephen R. van den BergAug 14, 2008
  6. Petr BaudisAug 14, 2008
  7. Stephen R. van den BergAug 14, 2008
  8. Shawn O. PearceAug 13, 2008
  9. Stephen R. van den BergAug 13, 2008
  10. Shawn O. PearceAug 13, 2008
  11. Stephen R. van den BergAug 14, 2008
  12. Shawn O. PearceAug 14, 2008
  13. Stephen R. van den BergAug 14, 2008
  14. Andreas EricssonAug 14, 2008
  15. Stephen R. van den BergAug 14, 2008
  16. david@lang.hmAug 14, 2008
  17. david@lang.hmAug 14, 2008
  18. Shawn O. PearceAug 14, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.