git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fsck: properly bound "invalid tag name" error message

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Dec 8, 2014, 11:01 UTC
Message-ID
<alpine.DEB.1.00.1412081200460.13845@s15462909.onlinehome-server.info>
In-Reply-To
<20141208054812.GA30154@peff.net>
Hi Peff,
On Mon, 8 Dec 2014, Jeff King wrote:
Show 9 quoted lines
> When we detect an invalid tag-name header in a tag object,
> like, "tag foo bar\n", we feed the pointer starting at "foo
> bar" to a printf "%s" formatter. This shows the name, as we
> want, but then it keeps printing the rest of the tag buffer,
> rather than stopping at the end of the line.
> 
> Our tests did not notice because they look only for the
> matching line, but the bug is that we print much more than
> we wanted to. So we also adjust the test to be more exact.
Good catch, thank you!
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Ciao, Dscho

Previous: Johannes Schindelin
Message 10 of 10 in “fsck: properly bound "invalid tag name" error message”
  1. fsck: properly bound "invalid tag name" error messageJeff King, Dec 8, 2014
  2. Jeff KingDec 8, 2014
  3. Johannes SchindelinDec 8, 2014
  4. Jeff KingDec 8, 2014
  5. Duy NguyenDec 8, 2014
  6. Johannes SchindelinDec 8, 2014
  7. Jeff KingDec 8, 2014
  8. Johannes SchindelinDec 8, 2014
  9. index-pack: terminate object buffers with NULJohannes Schindelin, Dec 8, 2014
  10. Johannes SchindelinDec 8, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.