From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 08 Dec 2014 11:01:13 GMT
Subject: Re: [PATCH] fsck: properly bound "invalid tag name" error message
Message-ID: <alpine.DEB.1.00.1412081200460.13845@s15462909.onlinehome-server.info>
In-Reply-To: <20141208054812.GA30154@peff.net>

Hi Peff,

On Mon, 8 Dec 2014, Jeff King wrote:

> When we detect an invalid tag-name header in a tag object,
> like, "tag foo bar\n", we feed the pointer starting at "foo
> bar" to a printf "%s" formatter. This shows the name, as we
> want, but then it keeps printing the rest of the tag buffer,
> rather than stopping at the end of the line.
> 
> Our tests did not notice because they look only for the
> matching line, but the bug is that we print much more than
> we wanted to. So we also adjust the test to be more exact.

Good catch, thank you!

Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Ciao,
Dscho