git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: First/oldest entry in reflog dropped

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Nov 21, 2010, 11:36 UTC
Message-ID
<alpine.DEB.1.00.1011211233570.2948@bonsai2>
In-Reply-To
<20101121053545.GA10520@sigill.intra.peff.net>
Hi,
On Sun, 21 Nov 2010, Jeff King wrote:
> This patch clears up your bug, and doesn't break any tests. But I'd 
> really like to get a second opinion on the significance of those other 
> flags, or why the flag clearing was at the bottom of the function in the 
> first place.

The flag clearing was at the bottom because I had the impression that something function one might want to call in that function in the future could set the flags again. Maybe a goto would be appropriate here instead of the early returns?

Ciao, Dscho

Previous: Jeff KingNext: Jeff King
Message 3 of 8 in “First/oldest entry in reflog dropped”
  1. Martin von ZweigbergkNov 21, 2010
  2. Jeff KingNov 21, 2010
  3. Johannes SchindelinNov 21, 2010
  4. Jeff KingNov 22, 2010
  5. Johannes SchindelinNov 22, 2010
  6. Junio C HamanoNov 24, 2010
  7. Jeff KingNov 25, 2010
  8. Martin von ZweigbergkNov 21, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.