git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: First/oldest entry in reflog dropped

From
Jeff King <peff@peff.net>
Date
Nov 25, 2010, 16:15 UTC
Message-ID
<20101125161530.GB24426@sigill.intra.peff.net>
In-Reply-To
<7vzksztv6f.fsf@alter.siamese.dyndns.org>
On Tue, Nov 23, 2010 at 04:35:52PM -0800, Junio C Hamano wrote:
Show 14 quoted lines
> > So let's do this, which is the equivalent behavior to your gotos, but
> > this structure makes more sense to me as a reader (and it doesn't
> > involve goto :) ).
> 
> I have a feeling that we probably should have structured the code a bit
> more modularly, placing some info in "rev" that tells us how to "pop" a
> commit from the rev->list (typically "not the ones that we have shown"),
> what other commits to push back into the queue (typically, "all the
> parents that are not interesting"), and what side effects we should cause
> when we do so (typically, "mark uninteresting parents"), etc., instead of
> the current "if we are walking reflog, here is the special codepath we
> take", so that the walking is more generalized when we did the reflog
> walking (in fact, if we did this properly we probably wouldn't be calling
> it "bolted on").  But for now let's refrain from doing such a rewrite.

FWIW, I agree with all of that. I don't think it's worth fixing now, but perhaps in libgit2. :)

-Peff
Previous: Junio C HamanoNext: Martin von Zweigbergk
Message 7 of 8 in “First/oldest entry in reflog dropped”
  1. Martin von ZweigbergkNov 21, 2010
  2. Jeff KingNov 21, 2010
  3. Johannes SchindelinNov 21, 2010
  4. Jeff KingNov 22, 2010
  5. Johannes SchindelinNov 22, 2010
  6. Junio C HamanoNov 24, 2010
  7. Jeff KingNov 25, 2010
  8. Martin von ZweigbergkNov 21, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.