git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [msysGit] [PATCH] submodules: ensure clean environment when operating in a submodule

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Feb 23, 2010, 00:04 UTC
Message-ID
<alpine.DEB.1.00.1002230103160.3609@intel-tinevez-2-302>
In-Reply-To
<1266877015-7943-1-git-send-email-giuseppe.bilotta@gmail.com>
Hi,
On Mon, 22 Feb 2010, Giuseppe Bilotta wrote:
Show 13 quoted lines
> git-submodule takes care of clearing GIT_DIR whenever it operates
> on a submodule index or configuration, but forgot to unset GIT_WORK_TREE
> before operating on the submodule worktree, which would lead to failures
> when GIT_WORK_TREE was set.
> 
> This only happened in very unusual contexts such as operating on the
> main worktree from outside of it, but since "git-gui: set GIT_DIR and
> GIT_WORK_TREE after setup" (a9fa11fe5bd5978bb) such failures could also
> be provoked by invoking an external tool such as "git submodule update"
> from the Git GUI in a standard setup.
> 
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
> ---

Heiko, would you say that this patch is an elegant solution to the problem you reported? If so, would you please pull it to 4msysgit.git's devel?

Thanks, Dscho

Previous: Giuseppe BilottaNext: Heiko Voigt
Message 13 of 15 in “submodules: ensure clean environment when operating in a submodule”
  1. submodules: ensure clean environment when operating in a submoduleGiuseppe Bilotta, Feb 22, 2010
  2. Junio C HamanoFeb 22, 2010
  3. Giuseppe BilottaFeb 22, 2010
  4. Junio C HamanoFeb 22, 2010
  5. 1/2 shell setup: clear_local_git_env() functionGiuseppe Bilotta, Feb 22, 2010
  6. Johannes SixtFeb 23, 2010
  7. Giuseppe BilottaFeb 23, 2010
  8. 0/2 clear environment for submodulesGiuseppe Bilotta, Feb 23, 2010
  9. 1/2 shell setup: clear_local_git_env() functionGiuseppe Bilotta, Feb 23, 2010
  10. Jens LehmannFeb 23, 2010
  11. 2/2 submodules: ensure clean environment when operating in a submoduleGiuseppe Bilotta, Feb 23, 2010
  12. 2/2 submodules: ensure clean environment when operating in a submoduleGiuseppe Bilotta, Feb 22, 2010
  13. Johannes SchindelinFeb 23, 2010
  14. Heiko VoigtFeb 23, 2010
  15. Johannes SchindelinFeb 23, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.