git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] submodules: ensure clean environment when operating in a submodule

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 22, 2010, 22:43 UTC
Message-ID
<7vljek51t1.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1266877015-7943-1-git-send-email-giuseppe.bilotta@gmail.com>
Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
> I'm pretty confident fixing this on the submodules side is the more correct
> approach, since otherwise even a simple
> $ GIT_WORK_TREE=. git submodule update
> on the command-line can fail.

True; while I didn't bother to check what the codepaths after these unsetting do, I suspect you should also think about what effect it has to have other GIT_* environment variables seep through to them (GIT_INDEX_FILE, GIT_CONFIG and GIT_OBJECT_DIRECTORY come to mind). You would probably want to have a single shell helper function to unset even if you end up deciding that it is sufficient to clear GIT_DIR and GIT_WORK_TREE and nothing else.

Previous: Giuseppe BilottaNext: Giuseppe Bilotta
Message 2 of 15 in “submodules: ensure clean environment when operating in a submodule”
  1. submodules: ensure clean environment when operating in a submoduleGiuseppe Bilotta, Feb 22, 2010
  2. Junio C HamanoFeb 22, 2010
  3. Giuseppe BilottaFeb 22, 2010
  4. Junio C HamanoFeb 22, 2010
  5. 1/2 shell setup: clear_local_git_env() functionGiuseppe Bilotta, Feb 22, 2010
  6. Johannes SixtFeb 23, 2010
  7. Giuseppe BilottaFeb 23, 2010
  8. 0/2 clear environment for submodulesGiuseppe Bilotta, Feb 23, 2010
  9. 1/2 shell setup: clear_local_git_env() functionGiuseppe Bilotta, Feb 23, 2010
  10. Jens LehmannFeb 23, 2010
  11. 2/2 submodules: ensure clean environment when operating in a submoduleGiuseppe Bilotta, Feb 23, 2010
  12. 2/2 submodules: ensure clean environment when operating in a submoduleGiuseppe Bilotta, Feb 22, 2010
  13. Johannes SchindelinFeb 23, 2010
  14. Heiko VoigtFeb 23, 2010
  15. Johannes SchindelinFeb 23, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.